-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] move contributing guide to docs and expand #2743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2743 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 44 44
Lines 5568 5568
=======================================
Hits 5229 5229
Misses 339 339 Continue to review full report at Codecov.
|
This is a nice improvement. One suggestion would be to consider adding in a guide for using a GUI interface (e.g., VSCode) to contribute. This removes the need to use the terminal to check out environments and use git which lowers the barrier for contributors that are comfortable with creating Julia scripts, but not running shell commands. Sadly, my current workload won't permit me to make such a contribution myself. One other suggestion, might be to mention that the tests can be run via including the |
I haven't used the VS code interface, so I'm not in a strong position to do this. I suggest we leave as-is for this PR, and improve things later if there is demand. |
I'll merge for now. If anyone has other suggestions, please open a PR or an issue. |
Closes #2675
I'll add a preview link once the build finishes.Preview: https://jump.dev/JuMP.jl/previews/PR2743/developers/contributing/