Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set Name attributes if unsupported #2704

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Do not set Name attributes if unsupported #2704

merged 3 commits into from
Sep 29, 2021

Conversation

odow
Copy link
Member

@odow odow commented Sep 23, 2021

Closes #2655

@odow odow added this to the 1.0 milestone Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #2704 (d40d9dc) into master (118b5ac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
+ Coverage   93.53%   93.54%   +0.01%     
==========================================
  Files          44       44              
  Lines        5444     5453       +9     
==========================================
+ Hits         5092     5101       +9     
  Misses        352      352              
Impacted Files Coverage Δ
src/constraints.jl 95.40% <100.00%> (+0.12%) ⬆️
src/variables.jl 98.56% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118b5ac...d40d9dc. Read the comment docs.

@odow odow merged commit e5a4258 into master Sep 29, 2021
@odow odow deleted the od/unsupported-names branch September 29, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Do not set names if the solver does not support it
2 participants