Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify callback gotchas #2688

Merged
merged 1 commit into from
Sep 18, 2021
Merged

[docs] Clarify callback gotchas #2688

merged 1 commit into from
Sep 18, 2021

Conversation

odow
Copy link
Member

@odow odow commented Sep 17, 2021

Closes #2642

@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #2688 (2ff1685) into master (f9bee2a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2688   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          44       44           
  Lines        5578     5578           
=======================================
  Hits         5218     5218           
  Misses        360      360

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9bee2a...2ff1685. Read the comment docs.

@odow odow merged commit bc7af42 into master Sep 18, 2021
@odow odow deleted the od/doc-callbacks branch September 18, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat left review comments

Assignees
No one assigned
Labels
Type: Documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document callback gotchas
2 participants
@odow @blegat