Remove incorrect and un-used copy functions #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
+ Coverage 91.86% 91.95% +0.09%
==========================================
Files 42 42
Lines 4463 4452 -11
==========================================
- Hits 4100 4094 -6
+ Misses 363 358 -5
Continue to review full report at Codecov.
|
blegat
approved these changes
Dec 15, 2020
|
Going to wait for @mlubin to see this and decide if we want to remove these functions. |
mlubin
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2407
Technically, this is a breaking change, but the definitions are old and incorrect, so no one should be relying on them.