Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the src/_Derivatives submodule #2383

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Format the src/_Derivatives submodule #2383

merged 2 commits into from
Nov 27, 2020

Conversation

odow
Copy link
Member

@odow odow commented Nov 27, 2020

Following #2292, run the formatter over src/_Derivatives.

format("src/_Derivatives";
    margin = 80,
    always_for_in = true,
    remove_extra_newlines = true,
    always_use_return = true,
)

There are some `return nothing's that JuliaFormatter doesn't get rid of.

  * margin = 80
  * always_for_in = true
  * remove_extra_newlines = true
  * always_use_return = true
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #2383 (6d96bcb) into master (a03543e) will increase coverage by 0.00%.
The diff coverage is 95.89%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2383   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          42       42           
  Lines        4442     4443    +1     
=======================================
+ Hits         4072     4073    +1     
  Misses        370      370           
Impacted Files Coverage Δ
src/_Derivatives/_Derivatives.jl 100.00% <ø> (ø)
src/_Derivatives/forward.jl 97.78% <92.68%> (ø)
src/_Derivatives/coloring.jl 98.03% <93.82%> (ø)
src/_Derivatives/conversion.jl 98.11% <100.00%> (ø)
src/_Derivatives/linearity.jl 97.95% <100.00%> (ø)
src/_Derivatives/reverse.jl 93.47% <100.00%> (ø)
src/_Derivatives/sparsity.jl 97.56% <100.00%> (+0.03%) ⬆️
src/_Derivatives/subexpressions.jl 100.00% <100.00%> (ø)
src/_Derivatives/topological_sort.jl 100.00% <100.00%> (ø)
src/_Derivatives/types.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03543e...6d96bcb. Read the comment docs.

@odow odow merged commit cb22f89 into master Nov 27, 2020
@odow odow deleted the od/format branch November 27, 2020 02:20
@odow odow mentioned this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants