-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin moving examples to Literate.jl and incorporate into documentation #2375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2375 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 42 42
Lines 4448 4448
=======================================
Hits 4072 4072
Misses 376 376 Continue to review full report at Codecov.
|
Can't we use We could link to the .jl file in the git repo so that it's trivial to copy the entire thing and past. Plus there is the binder thing that is used in https://jump.dev/SumOfSquares.jl/stable/generated/sos_decomposition/ |
This looks great! If we choose option 2, it will look a bit weird to have print statements that don't display, right? |
Yes. But I assume I can fix this somehow. My preference is for option 2 with prints. |
There are also some style questions. I wonder about only having |
I'm in favor of option 1. There is indeed more work for CI having to run it 3 times: for the doc, for the notebook and for the tests. However, the improvement of user experience seems to be worth it.
I agree |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge!
TODOs
This worked quite well. We have two options:
re-write examples, splitting into annotated parts
Pros:
Cons:
@test
and once as part of tests.minimal changes. Keep tests and function structure.
Pros:
@test
.Cons:
I think I prefer option 2.
Option 1
Option 2