Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Rewrite the C API using Clang.jl #128

Merged
merged 7 commits into from
Nov 29, 2021
Merged

[breaking] Rewrite the C API using Clang.jl #128

merged 7 commits into from
Nov 29, 2021

Conversation

odow
Copy link
Member

@odow odow commented Nov 28, 2021

This PR rewrites much of ECOS.jl in order to use the automated wrapper of the
C API generated by Clang.jl.

Closes #116
Closes #117

This PR rewrites much of ECOS.jl in order to use the automated wrapper of the
C API generated by Clang.jl.
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #128 (d9a184b) into master (c650e45) will decrease coverage by 3.13%.
The diff coverage is 84.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   79.25%   76.11%   -3.14%     
==========================================
  Files           4        3       -1     
  Lines         241      201      -40     
==========================================
- Hits          191      153      -38     
+ Misses         50       48       -2     
Impacted Files Coverage Δ
src/MOI_wrapper/permuted_exponential_cone.jl 87.50% <ø> (ø)
src/MOI_wrapper/MOI_wrapper.jl 74.13% <83.33%> (ø)
src/ECOS.jl 90.90% <90.00%> (-6.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c650e45...d9a184b. Read the comment docs.

@odow odow mentioned this pull request Nov 28, 2021
@odow odow merged commit 4b6487f into master Nov 29, 2021
@odow odow deleted the od/rewrite branch November 29, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update ECOS_jll to 2.0.8
1 participant