Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI badge #689

Merged
merged 1 commit into from
May 25, 2024
Merged

Update CI badge #689

merged 1 commit into from
May 25, 2024

Conversation

ericphanson
Copy link
Collaborator

I believe the current badge shows failing if the latest CI run was on a PR that was failing (maybe? I believe I saw this a few days ago at least). This one I got from github by going to https://github.com/jump-dev/Convex.jl/actions/workflows/ci.yml, clicking the 3 dots, and "create status badge":
Screenshot 2024-05-24 at 14 35 46

This changes the name to CI, but I kinda think that is better than "build status".

xref actions/starter-workflows#1525 (comment)

@odow
Copy link
Member

odow commented May 25, 2024

JuMP uses #branch=master, but this doesn't work for Convex because we don't run CI on each commit to master...

@odow odow merged commit 6bfcb89 into master May 25, 2024
1 check passed
@odow odow deleted the eph/badge branch May 25, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants