[test] update the recipe #1362
Merged
[test] update the recipe #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianpoy
reviewed
Apr 1, 2024
| imageIds: [], | ||
| folder: "main", | ||
| }); | ||
| expect(response.title).toEqual("marmelad"); |
There was a problem hiding this comment.
Would be good to query the DB again and check that it was properly updated in the database
julianpoy
reviewed
Apr 1, 2024
| }); | ||
| }); | ||
| describe("error", () => { | ||
| it("can not update unexisting recipe", async () => { |
There was a problem hiding this comment.
Would rename this case to throws an error when updating a recipe that does not exist
julianpoy
reviewed
Apr 1, 2024
| }).rejects.toThrow("Recipe not found"); | ||
| return tearDown(user2.id); | ||
| }); | ||
| it("must throw on invalid ownership", async () => { |
There was a problem hiding this comment.
Would suggest renaming this case to throws an error when updating a recipe with label ids the user does not own
julianpoy
reviewed
Apr 1, 2024
| return tearDown(user2.id); | ||
| }); | ||
|
|
||
| it("allows to update recipe with image", async () => { |
There was a problem hiding this comment.
This should be moved to the success section rather than the error section
|
Thanks for the PR! A few comments, but otherwise looks great! |
julianpoy
approved these changes
Apr 27, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests for updating the recipe