Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/firebase store location #1358

Merged
merged 9 commits into from
Mar 24, 2024
Merged

Fix/firebase store location #1358

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd5e82b
Merge pull request #1 from levyitay/feature/support_cloud_storage_option
levyitay Oct 28, 2022
dc285c3
Merge branch 'julianpoy:master' into master
levyitay Oct 31, 2022
5bc4ba9
Merge branch 'julianpoy:master' into master
levyitay Nov 7, 2022
3f1c625
Merge branch 'julianpoy:master' into master
levyitay Dec 26, 2022
8e99b75
Merge pull request #2 from julianpoy/master
levyitay Feb 17, 2023
3da1247
Merge branch 'julianpoy:master' into master
levyitay May 2, 2023
df67afb
Merge branch 'julianpoy:master' into master
levyitay Feb 3, 2024
064695b
fix(firebase-storage): firebase storage location should be uri encoded
levyitay Mar 24, 2024
2ae26da
Merge branch 'master' into fix/firebase-store-location
levyitay Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/backend/src/services/storage/firebase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const generateKey = (objectType: ObjectTypes): string => {

// Generate a public URL for the object
const generateStorageLocation = (key: string): string => {
const location = `https://firebasestorage.googleapis.com/v0/b/${BUCKET}/o/${key}?alt=media`;
const location = `https://firebasestorage.googleapis.com/v0/b/${BUCKET}/o/${encodeURIComponent(
key,
)}?alt=media`;

return location;
};
Expand Down