Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use centroid for aperture photometry #131

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Use centroid for aperture photometry #131

merged 3 commits into from
Sep 18, 2024

Conversation

juanep97
Copy link
Owner

This corrects against small astrometric inaccuracies.

@juanep97 juanep97 marked this pull request as ready for review August 30, 2024 09:40
@juanep97 juanep97 marked this pull request as draft August 30, 2024 09:40
@juanep97 juanep97 marked this pull request as ready for review September 6, 2024 09:20
Copy link
Collaborator

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, otherwise looks good

iop4lib/instruments/instrument.py Outdated Show resolved Hide resolved
iop4lib/instruments/instrument.py Show resolved Hide resolved
Copy link
Collaborator

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@morcuended morcuended merged commit 48a2669 into main Sep 18, 2024
5 checks passed
@morcuended morcuended deleted the aperture_phot branch September 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants