forbid-component-props: add component whitelist #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 23, 2018
| propName: { | ||
| type: 'string' | ||
| }, | ||
| allowedFor: { |
There was a problem hiding this comment.
let's make sure this list is unique
There was a problem hiding this comment.
done; didn't know json schema has an option to require uniqueness
lib/rules/forbid-component-props.js
Outdated
| const configuration = context.options[0] || {}; | ||
| const configuration = context.options[0] || {}; | ||
| const forbid = new Map((configuration.forbid || DEFAULTS).map(value => { | ||
| const propName = (typeof value === 'string') ? value : value.propName; |
There was a problem hiding this comment.
let's remove the redundant parens on the ternary conditionals here and below
|
Docs added, changes done. |
ThiefMaster
force-pushed
the
forbid-component-props
branch
from
cbcbcb2
to
805c8ea
Compare
ThiefMaster
added a commit
to ThiefMaster/indico
that referenced
this pull request
Mar 26, 2018
Until jsx-eslint/eslint-plugin-react#1735 is merged, then we can just whitelist ReactModal.
ThiefMaster
added a commit
to ThiefMaster/indico
that referenced
this pull request
Mar 26, 2018
Until jsx-eslint/eslint-plugin-react#1735 is merged, then we can just whitelist ReactModal.
ljharb
approved these changes
Apr 1, 2018
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
Apr 9, 2018
Until jsx-eslint/eslint-plugin-react#1735 is merged, then we can just whitelist ReactModal.
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
Apr 9, 2018
Switch back to a release once these PRs are merged and in a release: - jsx-eslint/eslint-plugin-react#1729 - jsx-eslint/eslint-plugin-react#1755 - jsx-eslint/eslint-plugin-react#1735
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
May 7, 2018
Until jsx-eslint/eslint-plugin-react#1735 is merged, then we can just whitelist ReactModal.
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
May 7, 2018
Switch back to a release once these PRs are merged and in a release: - jsx-eslint/eslint-plugin-react#1729 - jsx-eslint/eslint-plugin-react#1755 - jsx-eslint/eslint-plugin-react#1735
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
May 16, 2018
Until jsx-eslint/eslint-plugin-react#1735 is merged, then we can just whitelist ReactModal.
ThiefMaster
added a commit
to indico/indico
that referenced
this pull request
May 16, 2018
Switch back to a release once these PRs are merged and in a release: - jsx-eslint/eslint-plugin-react#1729 - jsx-eslint/eslint-plugin-react#1755 - jsx-eslint/eslint-plugin-react#1735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs are still missing ;)
fixes #1732