-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results of weekly scheduled smoke test #3371
Comments
cc @AriPerkkio on the "too long" error again. I see failures like: Repository: eManPrague/frui.ts
[535](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:536)
Rule: react/jsx-key
[536](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:537)
Message: Cannot read property 'type' of undefined
[537](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:538)
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/eManPrague/frui.ts/packages/validation/src/manualEntityValidator.ts:14
[538](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:539)
Rule: "react/jsx-key"
[539](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:540)
Path: eManPrague/frui.ts/packages/validation/src/manualEntityValidator.ts
[540](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:541)
Link: https://github.com/eManPrague/frui.ts/blob/HEAD/packages/validation/src/manualEntityValidator.ts#L14
[541](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:542)
[542](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:543)
12 |
[543](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:544)
13 | export default class ManualEntityValidator<TEntity = any> extends EntityValidatorBase<TEntity> {
[544](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:545)
> 14 | protected readonly validationResults = observable.map<PropertyName<TEntity>, ValidationResult[]>();
[545](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:546)
15 |
[546](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:547)
16 | constructor(isVisible = false, protected configuration: ManualEntityValidatorConfiguration = DefaultConfiguration) {
[547](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:548)
17 | super(isVisible); TypeError: Cannot read property 'type' of undefined
[611](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:612)
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qiekub/map/src/data/iD/modules/behavior/copy.js:50
[612](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:613)
Rule: "react/jsx-key"
[613](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:614)
at Object.isFunctionLikeExpression (/github/workspace/lib/util/ast.js:223:15)
[614](https://github.com/jsx-eslint/eslint-plugin-react/runs/8053911183?check_suite_focus=true#step:6:615)
at CallExpression[callee.type="MemberExpression"][callee.property.name="map"], CallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"], OptionalCallExpression[callee.type="MemberExpression"][callee.property.name="map"], OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"] (/github/workspace/lib/rules/jsx-key.js:230:22) I see at least 3 |
Something is still crashing even though I thought this was fixed in AriPerkkio/eslint-remote-tester-run-action#27. Here are results from logs.
2 | const baz = foo?.bar?.()?.[1] ?? 'qux';
3 |
> 4 | qux()?.map()
5 |
6 | const directiveRanges = comments?.map(tryParseTSDirective)
7 | Error:
8 |
9 | function base64SourceMap(source) {
> 10 | const base64 = Buffer.from(JSON.stringify(source.map()), 'utf8').toString(
11 | 'base64'
12 | );
13 | return `data:application/json;charset=utf-8;base64,${base64}`; Error:
|
@ljharb Looks like we are still using
|
Thanks for tagging me @AriPerkkio! Yeah, there seems to be a problem also in the |
I’ve got a fix ready for that one. |
0771bc1 is that fix. Rerunning the smoke test now. |
Detected 6 ESLint reports and/or crashes. Rules:
Click to expandRule: react/jsx-sort-props
33 | </AddonBlock>
34 | <AddonBlock>
> 35 | <ReactJson src={rowResult} name="data" collapsed={4} collapseStringsAfterLength={60} onEdit={onEdit} /* onDelete={onEdit} */ />
36 | </AddonBlock>
37 | </LayoutBlock>
38 | );
Rule: react/jsx-sort-props
43 | <title>circle</title>
44 | <g fill={`var(--spinner-${variant}-color)`}>
> 45 | <path
46 | fill={`var(--spinner-${variant}-color)`}
47 | d="M8,16c-1.199,0-2.352-0.259-3.428-0.77l0.857-1.807C6.235,13.806,7.1,14,8,14c3.309,0,6-2.691,6-6 s-2.691-6-6-6S2,4.691,2,8c0,0.901,0.194,1.766,0.578,2.572l-1.806,0.859C0.26,10.354,0,9.2,0,8c0-4.411,3.589-8,8-8s8,3.589,8,8 S12.411,16,8,16z" /* eslint-disable-line max-len */
48 | />
Rule: react/jsx-sort-props
245 | >
246 | <div className="dnb-core-style">
> 247 | <GlobalStatus
248 | id="modal"
249 | // title={'Title 1'}
250 | // demo
Rule: react/jsx-sort-props
185 | <FastForwardIcon color="inherit" />
186 | </IconButtonWithTooltip>
> 187 | <IconButtonWithTooltip
188 | color="inherit"
189 | tooltipText="Reload - WIP"
190 | disabled={true}
Rule: react/jsx-sort-props
831 | if (props.includeCard) {
832 | return (
> 833 | <Card
834 | title="Analyzer"
835 | className="analyzer-card"
836 | extra={analyzerControls}
Rule: react/jsx-sort-props
11 | <>
12 | {props.labelText}
> 13 | <Tooltip title={props.help} color="black" /* otherwise it's not opaque */>
14 | <QuestionCircleOutlined
15 | className="readable-text-color"
16 | style={{ marginLeft: 5, color: 'cyan' }}
|
On this one, avoiding the crash is easy, but making the test case have correct output seems to have unveiled a larger bug (cc @ROSSROSALES) |
@ljharb Thanks for tagging me. I will take a look at this as soon as I can to find a fix. It seems like the rule is finding >1 line comments in between two props of a multi-lined component and block comments allocated at the end of the last prop of a multi-lined component. |
@ROSSROSALES the issue i'm seeing is that it's autofixing to |
I tried a fix to the issue. I added the quoted test case. |
oh sure, yes - it's the change to a boolean that i'm concerned about :-) |
I believe the fix should fix the boolean problem! But if I am not understanding the issue correctly please let me know or if the fix was not appropriate. I will try my best to solve this issue. |
Something went wrong.
Click to expand
The text was updated successfully, but these errors were encountered: