-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: jsx-no-leaked-render
faulty autofix
#3323
Comments
cc @Belco90 |
The exclamation points definitely seem like a bug that should be fixed, and i agree that the The autofixer's performance is something that can be improved separately, but isn't as concerning. |
I bet the bad performance is related to adding many negations. I'll try to take a look soon. |
I identified the issue but I need more time to rework the fix functionality to solve it. |
@Belco90 I created a PR to fix the multiple |
That's amazing! I'll try to review it later today. Thanks. |
It ensures jsx-eslint#3323 is fixed.
It ensures jsx-eslint#3323 is fixed.
I'm having a similar experience: Original{!sourceQuestData && loadingSourceQuest && (
<StyledInfoLine>
<Icon name="info" size={40} />
<ActivityIndicator size="small" />
</StyledInfoLine>
)} Result{!!!!!!!!!!!!!!!!!!!sourceQuestData && loadingSourceQuest && (
<StyledInfoLine>
<Icon name="info" size={40} />
<ActivityIndicator size="small" />
</StyledInfoLine>
)} Similar to the OP, the Adding to booleansI also see it adding const showComponent = editMode || item.status === "COMPLETED";
return (
<>
{!!showComponent && (...)}
</>
) |
This should be fixed by #3353. |
Version: 7.30.1
Config:
Before fix:
Post fix:
Expected:
On top of that, the auto fix is quite slow.
The text was updated successfully, but these errors were encountered: