Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy compatibility #703

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

jhonatan-lopes
Copy link
Contributor

Add py.typed to package data to ensure that it is included when building. Include zip_safe=False per mypy's instructions. See #698.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #703 (f6cecb6) into develop (446abb7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #703   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1410      1410           
=========================================
  Hits          1410      1410           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jhonatan-lopes
Copy link
Contributor Author

@jsvine, could you please test this with your usual build process and check whether py.typed is now included in the source and built distributions?

@jsvine
Copy link
Owner

jsvine commented Aug 5, 2022

@jsvine, could you please test this with your usual build process and check whether py.typed is now included in the source and built distributions?

Yep, that fixed the issue! Many thanks, merging 👍

@jsvine jsvine merged commit 6908487 into jsvine:develop Aug 5, 2022
@jsvine jsvine mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants