-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing any angular version greater than 13 #668
Conversation
@dfa1234 Thanks for the PR! |
This reverts commit ceb2758.
@shaharkazaz Thank to you Lately now I'm really into Nx so I'm very glad to try what ( I think ) you suggest do to. The only problem is that when I'm doing |
@dfa1234 I'm not sure I understand, the change you made should cover it. |
@shaharkazaz My commands are: rm -rf ~/.nx # just to be sure there is no cache here!
git clone git@github.com:ngneat/transloco.git
cd transloco/
npm i
npm run build:scoped-libs
cat dist/libs/transloco-scoped-libs/package.json # to see what we have here WITHOUT ANY CHANGESHere the result I have: {
"name": "@ngneat/transloco-scoped-libs",
"version": "3.0.5",
"description": "Transloco support tool for libraries with translations",
"main": "src/lib/transloco-scoped-libs.js",
"bin": {
"transloco-scoped-libs": "src/index.js"
},
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://github.com/ngneat/transloco/issues"
},
"homepage": "https://ngneat.github.io/transloco/docs/tools/scope-lib-extractor",
"repository": {
"type": "git",
"url": "https://github.com/ngneat/transloco"
},
"keywords": [
"angular",
"angular 2",
"i18n",
"translate",
"angular translate",
"angular i18n",
"transloco",
"comments",
"build",
"optimize"
],
"license": "MIT",
"author": "Itay Oded",
"contributors": [
{
"name": "Shahar Kazaz",
"url": "https://github.com/shaharkazaz"
},
{
"name": "Netanel Basal",
"url": "https://netbasal.com"
}
],
"dependencies": {
"@angular/animations": "16.0.4",
"@angular/common": "16.0.4",
"@angular/compiler": "16.0.4",
"@angular/core": "16.0.4",
"@angular/platform-browser": "16.0.4",
"@angular/platform-browser-dynamic": "16.0.4",
"@ngneat/transloco-utils": "^3.0.5",
"chalk": "4.1.2",
"chokidar": "3.5.2",
"command-line-args": "5.2.0",
"cosmiconfig": "8.1.3",
"fs-extra": "9.1.0",
"glob": "7.1.7",
"rxjs": "7.8.0",
"tslib": "2.3.1",
"zone.js": "0.13.0"
},
"types": "./src/index.d.ts"
} WITH MY CHANGEI added {
"name": "@ngneat/transloco-scoped-libs",
"version": "3.0.5",
"description": "Transloco support tool for libraries with translations",
"main": "src/lib/transloco-scoped-libs.js",
"bin": {
"transloco-scoped-libs": "src/index.js"
},
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://github.com/ngneat/transloco/issues"
},
"homepage": "https://ngneat.github.io/transloco/docs/tools/scope-lib-extractor",
"repository": {
"type": "git",
"url": "https://github.com/ngneat/transloco"
},
"keywords": [
"angular",
"angular 2",
"i18n",
"translate",
"angular translate",
"angular i18n",
"transloco",
"comments",
"build",
"optimize"
],
"license": "MIT",
"author": "Itay Oded",
"contributors": [
{
"name": "Shahar Kazaz",
"url": "https://github.com/shaharkazaz"
},
{
"name": "Netanel Basal",
"url": "https://netbasal.com"
}
],
"dependencies": {
"@ngneat/transloco-utils": "^3.0.5",
"chalk": "^4.1.2",
"chokidar": "^3.5.2",
"command-line-args": "^5.1.1",
"glob": "^7.1.7",
"fs-extra": "^9.1.0"
},
"types": "./src/index.d.ts"
} Here what I have right now for you, maybe I will try to perform a complete build to see if it differ from this |
The 2nd package seems correct. |
My concern is that the result with or without the flag slightly differ from what there is in npm right now: package.json version 3.0.5 Here we have (wrong) peerDependencies: {
"name": "@ngneat/transloco-scoped-libs",
"version": "3.0.5",
"description": "Transloco support tool for libraries with translations",
"main": "src/lib/transloco-scoped-libs.js",
"bin": {
"transloco-scoped-libs": "src/index.js"
},
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://github.com/ngneat/transloco/issues"
},
"homepage": "https://ngneat.github.io/transloco/docs/tools/scope-lib-extractor",
"repository": {
"type": "git",
"url": "https://github.com/ngneat/transloco"
},
"keywords": [
"angular",
"angular 2",
"i18n",
"translate",
"angular translate",
"angular i18n",
"transloco",
"comments",
"build",
"optimize"
],
"license": "MIT",
"author": "Itay Oded",
"contributors": [
{
"name": "Shahar Kazaz",
"url": "https://github.com/shaharkazaz"
},
{
"name": "Netanel Basal",
"url": "https://netbasal.com"
}
],
"dependencies": {
"@ngneat/transloco-utils": "^3.0.5",
"chalk": "^4.1.2",
"chokidar": "^3.5.2",
"command-line-args": "^5.1.1",
"glob": "^7.1.7",
"fs-extra": "^9.1.0"
},
"typings": "./src/index.d.ts",
"peerDependencies": {
"cosmiconfig": "^8.1.3",
"tslib": "2.3.1",
"zone.js": "0.11.5",
"@angular/core": "13.3.10",
"@angular/platform-browser-dynamic": "13.3.10"
}
}
|
* origin/master: fix(transloco-scoped-libs): 🐛 remove unwanted peerDependencies (#668)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When we use any angular version > major release 13 it's like:
Issue Number: #646
What is the new behavior?
No log complaing we should force for scoped libs utils
Does this PR introduce a breaking change?