Expands Warning.STRICT_INHERITANCE to remove the need to call usingGe…

…tClass()

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Renames the project's main branch to `main`.
 - Replaces all references to the word 'black' to 'blue', including those in internal (but accessible) API's.
+- `Warning.STRICT_INHERITANCE` now also takes away the requirement to call `#usingGetClass()`
 
 ### Fixed
 - Testing a class with that has fields but doesn't override `equals` causes "Mutability: equals depends on mutable field" error. ([Issue 315](https://github.com/jqno/equalsverifier/issues/315))

src/main/java/nl/jqno/equalsverifier/Warning.java

@@ -130,12 +130,14 @@ public enum Warning {
     STRICT_HASHCODE,
 
     /**
-     * Disables some of the stricter inheritance tests; use at your own risk!
+     * Disables some of the stricter inheritance tests.
      *
      * <p>{@link EqualsVerifier}'s standard behaviour, if T is not final and neither are its {@code
      * equals} and {@code hashCode} methods, is to require a reference to a subclass of T for which
      * no instance can be equal to any instance of T, to make sure that subclasses that can redefine
-     * {@code equals} or {@code hashCode} don't break the contract.
+     * {@code equals} or {@code hashCode} don't break the contract; or it asks to call the {@code
+     * usingGetClass} method if T uses {@code getClass()} instead of {@code instanceof} in its
+     * {@code equals} method.
      *
      * <p>Some may find that too strict for their liking; suppressing this warning disables that
      * test.

src/main/java/nl/jqno/equalsverifier/internal/checkers/HierarchyChecker.java

@@ -126,7 +126,7 @@ private Object getEqualSuper(T reference) {
     }
 
     private void checkSubclass() {
-        if (typeIsFinal) {
+        if (typeIsFinal || config.getWarningsToSuppress().contains(Warning.STRICT_INHERITANCE)) {
             return;
         }
 

src/test/java/nl/jqno/equalsverifier/integration/extra_features/GetClassTest.java

@@ -3,6 +3,7 @@
 import static nl.jqno.equalsverifier.testhelpers.Util.defaultHashCode;
 
 import nl.jqno.equalsverifier.EqualsVerifier;
+import nl.jqno.equalsverifier.Warning;
 import nl.jqno.equalsverifier.testhelpers.ExpectedExceptionTestBase;
 import nl.jqno.equalsverifier.testhelpers.types.Color;
 import nl.jqno.equalsverifier.testhelpers.types.FinalMethodsPoint;
@@ -11,11 +12,18 @@
 import org.junit.Test;
 
 public class GetClassTest extends ExpectedExceptionTestBase {
+
     @Test
     public void succeed_whenEqualsUsesGetClassInsteadOfInstanceof_givenUsingGetClassIsUsed() {
         EqualsVerifier.forClass(GetClassPoint.class).usingGetClass().verify();
     }
 
+    @Test
+    public void
+            succeed_whenEqualsUsesGetClassInsteadOfInstanceof_givenWarningStrictInheritanceIsSuppressed() {
+        EqualsVerifier.forClass(GetClassPoint.class).suppress(Warning.STRICT_INHERITANCE).verify();
+    }
+
     @Test
     public void fail_whenEqualsUsesGetClassButForgetsToCheckNull_givenUsingGetClassIsUsed() {
         expectFailureWithCause(