Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for static_assert declaration #797

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Add support for static_assert declaration #797

merged 3 commits into from
Dec 14, 2023

Conversation

jaquish
Copy link
Contributor

@jaquish jaquish commented Nov 30, 2023

No description provided.

@johnfairh
Copy link
Collaborator

Thanks for this -- could you please add a changelog entry, see CONTRIBUTING.md?

@jaquish
Copy link
Contributor Author

jaquish commented Dec 12, 2023

Thanks for the pointer @johnfairh. Updated.

@johnfairh
Copy link
Collaborator

Hi @jpsim does this look OK to squash + merge? There are Bazel CI failures that I don't understand but must be unrelated?

jpsim
jpsim approved these changes Dec 14, 2023
View reviewed changes
Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, yes the bezel failures are unrelated.

@jpsim jpsim merged commit 8abd090 into jpsim:main Dec 14, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaquish @johnfairh @jpsim