🐛 Fix issue #223, ensure trailing forward slash baseURL during search index build #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully fixes issue #223, where search functionality was broken from website deployed to netlify
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for this fix, @eliaserland. I've tested the change and it works. I can't see any reason why this would break any other build configurations as the base URL should always end in a forward slash so I'll go ahead and merge this in. |
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #223.
Should now hopefully verify that
baseURLcontains a trailing forward slash. This fixes my personal issue with search not working, hopefully it doesn't break anyone else's search.