test:lint Lint added for test folder and also fixed intial level of lint errors #25280 #25288
Conversation
saquibkhan
force-pushed
the
fix-issue-25280
branch
from
7e761b6
to
c54e9c1
Compare
|
@misterdjules thanks for the comment. I have updated the code accordingly. |
|
@joyent/node-coreteam Now that I'm thinking about it, I would actually advocate for landing that in v0.12. If we land this in master, it's going to be painful when we merge changes in tests from v0.12 to master because the two will have diverged significantly. It would probably not require any change to #25280 since master and v0.12 are probably identical currently. |
|
@misterdjules Done! |
|
@saquibkhan Thanks, let's wait for @joyent/node-coreteam to give us some feedback on my proposal for landing this in v0.12 instead of master, and then we'll do a thorough code review (although at first sight changes look good). Thank you once again! 👍 |
|
@misterdjules yes, 0.12 makes more sense since there should be no behavior change. |
saquibkhan
force-pushed
the
fix-issue-25280
branch
2 times, most recently
from
5f99d62
to
d2671a4
Compare
Added closure linter for test folder. Fixed 2k+ issues in 300 files. After this fix there is no lint error in test scripts. Fixes nodejs#25280
saquibkhan
force-pushed
the
fix-issue-25280
branch
from
d2671a4
to
a248653
Compare
|
@misterdjules @cjihrig ... what would you like to do with this one? |
|
The converged repo uses ESLint. I don't personally see a need for this, but others might. |
|
Hmm.. I'm inclined to close. If someone wanted to do this in v0.12 a new PR can be opened |
|
Closing this one here. Can revisit if necessary but it's not likely to land. |
test:lint Lint added for test folder and also fixed intial level of lint errors
Added closure linter for test folder. Fixed 2k+ issues in 300 files.
Fixes #25280