Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent 'Incorrect datetime value' MySQL error #108

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Prevent 'Incorrect datetime value' MySQL error #108

merged 2 commits into from
Jun 27, 2019

Conversation

davidgrayston
Copy link
Contributor

I experienced the following error when running site:install with MySQL 5.7:

ERROR 1292 (22007) at line 1: Incorrect datetime value: '0000-00-00 00:00:00' for column 'lastResetTime' at row 1
  • MySQL 5.6 doesn't have this issue.
  • Using NOW() resolves this issue.

Read more about SQL Mode Changes in MySQL 5.7 and NO_ZERO_IN_DATE

@stevenrombauts stevenrombauts merged commit 1314044 into joomlatools:master Jun 27, 2019
@stevenrombauts
Copy link
Member

@davidgrayston Excellent catch, thanks for the PR!

@stevenrombauts stevenrombauts added this to the 1.6 milestone Jun 27, 2019
@stevenrombauts stevenrombauts modified the milestones: 1.6, 1.5.4 Jul 12, 2019
@davidgrayston davidgrayston deleted the site-install-mysql-5-7 branch January 18, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgrayston @stevenrombauts