Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Bootstrap 5.0 plus more #33576

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

brianteeman
Copy link
Contributor

This PR updates several npm packages

Of note are

Bootstrap 5.0

twbs/bootstrap@v5.0.0-beta3...v5.0.0

Codemirror 5.6.10

https://codemirror.net/doc/releases.html

TinyMCE 5.8.0

https://www.tiny.cloud/docs/changelog/

This PR updates several npm packages

Of note are

Bootstrap 5.0

Codemirror

TinyMCE
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 6, 2021
@wilsonge wilsonge merged commit 60e33f7 into joomla:4.0-dev May 6, 2021
@wilsonge
Copy link
Contributor

wilsonge commented May 6, 2021

I'm going to merge this as the tests are passing so superficially things work - and given we've also got the new UI in as well these can be tested together in nightlies (I'll trigger a fresh nightly now)

@brianteeman
Copy link
Contributor Author

agreed - thanks

@brianteeman brianteeman deleted the keep_phil_happy branch May 6, 2021 14:28
@zero-24 zero-24 added this to the Joomla 4.0 milestone May 7, 2021
@ReLater
Copy link
Contributor

ReLater commented May 10, 2021

Just as info: Grave bug in BS5 javascript under some circumstances. But shouldn't concern Joomla 4 core at the moment(?). Haven't tested.
twbs/bootstrap#33840

@HLeithner
Copy link
Member

Just as info: Grave bug in BS5 javascript under some circumstances. But shouldn't concern Joomla 4 core at the moment(?). Haven't tested.
twbs/bootstrap#33840

Doesn't effect us because we load BS at the end of the body tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants