Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows ACME Simple (win-acme) to clients list #134

Merged
merged 4 commits into from
Feb 22, 2019

Conversation

Daniel15
Copy link
Contributor

win-acme is probably the easiest open-source client to use on Windows, and as of the latest alpha it supports acme-dns 😃

@Daniel15 Daniel15 changed the title Add win-acme to clients list Add Windows ACME Simple (win-acme) to clients list Jan 22, 2019
@joohoi
Copy link
Owner

joohoi commented Jan 22, 2019

Thanks for the PR! I would prefer to add it when it's got a non-alpha release supporting acme-dns. Would it be possible to modify the PR to remove the version info, and we'll merge when it's released? They seem to have a pretty active release cycle, so it shouldn't take too long!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.903% when pulling 64349b7 on Daniel15:patch-3 into 2da94f1 on joohoi:master.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Coverage Status

Coverage remained the same at 93.676% when pulling 9bcab4c on Daniel15:patch-3 into 5d74ff1 on joohoi:master.

@Daniel15
Copy link
Contributor Author

Sure, will wait until the stable release 😄

@WouterTinus WouterTinus mentioned this pull request Jan 30, 2019
@WouterTinus
Copy link
Contributor

I've just released a stable version with acme-dns support, so feel free to merge when convenient!

@joohoi
Copy link
Owner

joohoi commented Feb 22, 2019

Awesome, thanks for the update!

@joohoi joohoi merged commit 395cb7a into joohoi:master Feb 22, 2019
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
* Add win-acme to clients list

* Use its official name ("Windows ACME Simple")

* Remove version number from WACS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants