Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: fix NS address in test command #115

Merged
merged 1 commit into from
Sep 28, 2018
Merged

README: fix NS address in test command #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ Note: The `txt` field must be exactly 43 characters long, otherwise acme-dns wil

4) Perform a DNS lookup to the test subdomain to confirm that everything is working properly:
```
$ dig @ns.auth.example.org d420c923-bbd7-4056-ab64-c3ca54c9b3cf.auth.example.org
$ dig @auth.example.org d420c923-bbd7-4056-ab64-c3ca54c9b3cf.auth.example.org
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the @auth.example.org should not be required at all. If the DNS setup is correct, this server should be queried eventually anyway.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. And for testing purposes, even more usable actually. The current format is probably more usable for troubleshooting scenarios.

In general, I feel that the README.md should get restructured, and internally linked. For example, installation should link to the DNS configuration section, and testing it out to the (hopefully upcoming) troubleshooting section. Ideally these should follow each other in the document itself. I'll create an issue for that.

```

## Configuration
Expand Down