Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN-1352 | Remove events API for move to Github App #211

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

zrosenbauer
Copy link
Member

@zrosenbauer zrosenbauer commented Jun 11, 2022

🚀 BlueNova Deployment | Preview Url: https://pvw-bluenova-ghaexample-pr211-d4keqmet5a-uc.a.run.app


By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@zrosenbauer zrosenbauer self-assigned this Jun 11, 2022
@zrosenbauer zrosenbauer added enhancement New feature or technical improvement. blocked There is an issue and this MUST NOT be released. labels Jun 11, 2022
dockerfile,
projectId: launchpad.projectId,
slug: launchpad.slugId,
buildArgs: (0, parser_1.parseListInputs)(buildArgs),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSC_USELESS_CODE: Suspicious code. This code lacks side-effects. Is there a bug?

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

dockerfile,
projectId: launchpad.projectId,
slug: launchpad.slugId,
buildArgs: (0, parser_1.parseListInputs)(buildArgs),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSC_USELESS_CODE: Suspicious code. This code lacks side-effects. Is there a bug?

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@zrosenbauer zrosenbauer removed the blocked There is an issue and this MUST NOT be released. label Jun 14, 2022
@zrosenbauer zrosenbauer merged commit d3fd2f5 into main Jun 14, 2022
@zrosenbauer zrosenbauer deleted the feature/BN-1352 branch June 14, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or technical improvement.
Development

Successfully merging this pull request may close these issues.

1 participant