test: add our own src/ directory to the search path #153
Conversation
As an artefact of the recent move of the module into the src/ folder, the unit tests cannot find the local package anylonger. Worse still, with a sufficiently compatible version of hawkmoth available in the system path, we may be duped into thinking the tests are working when they aren't.
What you need to do is in That installs hawkmoth in the virtual environment in editable mode using This means testing hawkmoth as it is installed, not directly from Python path. And one of the main points of the whole This helps catch the kind of embarrassing packaging mistakes I made with v0.13. So I'm rejecting this one.
Meh. I've looked at it several times, and it's not a simple conversion. |
|
Hmm, I thought that was meant to be covered by CI but that we would still support an easy and quick way of testing without it locally. Though I guess this would have to be done differently even then. To tell the truth, I stay away from venvs as much as possible. But I guess it's easy enough to carry around a workaround on my side for now so I'll do that.
Yup, got the same impression :/ |
So I finally got around to try and package the newest version for Arch and discovered I couldn't run the tests with a simple
make test.No idea just yet if this will break the CI. Not sure why / how it's running in CI either, though I confess I haven't looked too hard into it. Either way, I am positive that
make testwas trying to run my old system installation of hawkmoth and this fixes it for me.Not so related, and not sure if you had already commented on that, but
sphinx-testingis now properly deprecated. I'm currently running an unmaintained version. We're probably on borrowed time here and we'll have to convert to the built insphinx.testingsoon :/