Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for legacy unquoted string literals #32

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

grddev
Copy link
Contributor

@grddev grddev commented May 23, 2016

While we definitely want to transition away from unquoted string literals, it seems reasonable to do that over time, similarly to how it was handled in jmespath.py.

The reason for doing so, is to allow for a simple upgrade path, where a new version of jmespath.rb can be installed, and the software using it can transition all its configuration to use the new format, and then the jmespath.rb version could be upgraded to not even support these expressions.

The tests were copied verbatim from jmespath.py, and are not included in the compliance test suite, so comes with an explicit license, which the compliance test suite does not. JSON doesn't allow for comments, so I'm not sure how to handle the attribution clause of the jmespath.py license

While we definitely want to transition away from unquoted string
literals, it seems reasonable to do that over time, similarly to how it
was handled in jmespath.py.

The reason for doing so, is to allow for a simple upgrade path, where a
new version of jmespath.rb can be installed, and the software using it
can transition all its configuration to use the new format, and then the
jmespath.rb version could be upgraded to not even support these
expressions.

The tests were copied verbatim from jmespath.py, and are not included in
the compliance test suite, so comes with an explicit license, which the
compliance test suite does not. JSON doesn't allow for comments, so I'm
not sure how to handle the attribution clause of the jmespath.py license
@trevorrowe trevorrowe merged commit 95ac4b0 into jmespath:master Jul 7, 2016
@trevorrowe
Copy link
Contributor

Thanks for the fix! I've merged this and it should be part of the 1.3 release shortly. I'm not sure what the best path to deal with the license. I'll talk to @jamesls and see if anything is needed. Given this repo lives in the JMESPath org, it should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants