Fixed some issues caused by dereferencing pointers to elements of an … #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues caused by dereferencing pointers to elements of an std::vector that has since been re-allocated.
Some comments:
_originalVertices
doesn't have to be a member variable, since we only use it inside theprocessContours
function. But it should be more efficient like this, since making it local to the function would cause it to re-allocate every time.vertexDataCallback
: I replaced theif (vertex_data[i] != nullptr)
withif (weight[i] > 0.0f)
, since we're no longer passing pointers but instead index values directly, and an index of 0 would cause the null-check to fail.#76