Implemented some CityObjectElements and enabled tesselate #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed using this library externally
jklimke
requested changes
Feb 3, 2022
There was a problem hiding this comment.
First of all: Thank you for you contribution.
Please have a look at the annotations i did, please adapt the import style. As far as i remember public headers, i.e., the ones starting with 'citygml' should be imported using import <header_name>
Changing the default tesselation to false may break other applications that use the library as the behaviour changes.
* release: Aligned the format Fixed for jklimke#62 (review)
|
@jklimke |
|
Thank you for your checking and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I updated the following points of libcitygml.
This commit successes parsing 533925_tran_6697_op2.gml.
Please check and merge this.