Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: 로그 저장 경로를 backend/logs로 원복 #629

Merged
merged 5 commits into from
Aug 2, 2023
Merged

fix!: 로그 저장 경로를 backend/logs로 원복 #629

merged 5 commits into from
Aug 2, 2023

Conversation

scarf005
Copy link
Member

개요

#609 의 main 브랜치 대상 핫픽스

@scarf005 scarf005 temporarily deployed to development July 31, 2023 08:51 — with GitHub Actions Inactive
@scarf005 scarf005 marked this pull request as draft July 31, 2023 08:51
@scarf005 scarf005 marked this pull request as ready for review July 31, 2023 09:07
jimin52
jimin52 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jimin52 jimin52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경내역

  • .env 환경변수 추가
  • logger 디렉토리 변경
  • Dockerfile WORKDIR 변경에 따른 compose 변경
    확인했습니다.

nyj001012
nyj001012 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@nyj001012 nyj001012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/src/config/logOption.ts
@@ -1,4 +1,4 @@
import { LogLevel, LogLevelOption } from './config.type';
import type { LogLevel, LogLevelOption } from './config.type';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS 3.8에서 추가된 문법이네요!

@scarf005 scarf005 merged commit d5c18ac into main Aug 2, 2023
3 checks passed
@scarf005 scarf005 deleted the 608-logs-생성-경로가-올바르지-않음 branch August 2, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimin52 jimin52 jimin52 approved these changes

@nyj001012 nyj001012 nyj001012 approved these changes

Assignees

@jimin52 jimin52

@nyj001012 nyj001012

@scarf005 scarf005

Labels
None yet
Projects
집현전 v2 리팩터링
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarf005 @jimin52 @nyj001012