Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 빌드 가능 여부 테스트 #585

Merged
merged 3 commits into from
Jul 23, 2023
Merged

ci: 빌드 가능 여부 테스트 #585

merged 3 commits into from
Jul 23, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jul 16, 2023 •
edited
Loading

개요

develop을 main에 머지하기 전에 PR이 CI 환경에서 빌드가 가능한지 확인합니다.

변경점

  • jest 등 테스트 프레임워크 실행시 NodeEnv 환경변수에 test 값이 들어가는 것을 확인해, config environment 스키마에 추가해주었습니다.
  • 기존 대기시간, 로그레벨 등은 development와 production만 가정했는데, test도 고려해
    • 로그 레벨은 production은 http, development와 test는 debug 모드로,
    • 서버 종료 대기 시간은 production만 30초 대기, development와 test는 대기하지 않는 식으로 바꾸었습니다.

@scarf005 scarf005 temporarily deployed to production July 16, 2023 05:19 — with GitHub Actions Inactive
@scarf005 scarf005 requested a review from jimin52 July 16, 2023 05:19
@scarf005 scarf005 temporarily deployed to production July 16, 2023 05:56 — with GitHub Actions Inactive
@scarf005 scarf005 requested a review from nyj001012 July 18, 2023 01:57
@scarf005 scarf005 temporarily deployed to development July 18, 2023 02:01 — with GitHub Actions Inactive
jimin52
jimin52 approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@jimin52 jimin52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/src/config/runtimeOption.ts Show resolved Hide resolved
@scarf005 scarf005 merged commit e42d379 into develop Jul 23, 2023
2 checks passed
@scarf005 scarf005 deleted the check-build branch July 23, 2023 00:56
nyj001012 pushed a commit that referenced this pull request Jul 31, 2023
@scarf005 @nyj001012
ci: 빌드 가능 여부 테스트 (#585)
e9b4eab 
* ci: docs job 이름을 deploy와 겹치지 않게 변경

* ci: PR 빌드 가능 여부 테스트

* test: NODE_ENV에서 test값 허용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimin52 jimin52 jimin52 approved these changes

@nyj001012 nyj001012 Awaiting requested review from nyj001012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarf005 @jimin52