-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
455 태그 생성 기능 추가 #473
Merged
The head ref may contain hidden characters: "455-\uD0DC\uADF8-\uC0DD\uC131-\uAE30\uB2A5-\uCD94\uAC00"
Merged
455 태그 생성 기능 추가 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
컨트롤러 틀 생성
엔티티 수정
컨트롤러 추가
서비스 구현
라우터 인덱스 추가
bookInfoId 컬럼추가
경로 재설정 및 불필요한 코드 제거
레포지토리 추가
entity 정의 부분 lint에 맞게 수정
import 정상 작동하도록 수정
eslint 수정
eslint 수정
getDefaultTagId 함수 추가
Tag Error Code 추가
'userid' 에서 'userId' 으로 변경
Repository 함수 변경
함수 추가 및 마이너한 변경
eslint 수정
service.ts 에서 객체를 export하는 게 아니라 클래스를 export하게 함
class default 삭제
wrapAsyncController 제거
HTTP 응답값 변경
regex 추가
tag의 input값이 유효한지 확인하는 모듈을 controller에서 동작하도록 수정
라우트 경로설정
주석 삭제 및 슈퍼태그 함수 생성
컨텐트 trim 추가
delete routes 추가
컨트롤러 delete Super/Sub 태그 생성
리포지토리 delete Super/Sub 태그 생성
서비스 delete Super/Sub 태그 추가
routes 경로 설정
변수명 재설정
nyj001012
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
태그 생성기능 추가
작업 사항
기능 추가
변경점
기능 추가
목적
태그 생성
스크린샷 (optional)