Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check dtype when loading models #872

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix: check dtype when loading models #872

merged 2 commits into from
Dec 7, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Dec 7, 2022

The dtype is automatically set to torch.float16 when running on GPU.
This pr fixes dtype checking logics to unblock torch.float16

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #872 (e38c854) into main (1eebdd7) will increase coverage by 10.34%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #872       +/-   ##
===========================================
+ Coverage   70.69%   81.04%   +10.34%     
===========================================
  Files          22       22               
  Lines        1498     1498               
===========================================
+ Hits         1059     1214      +155     
+ Misses        439      284      -155     
Flag Coverage Δ
cas 81.04% <100.00%> (+10.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/model.py 75.09% <100.00%> (ø)
server/clip_server/model/trt_utils.py 56.04% <0.00%> (+56.04%) ⬆️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (+69.38%) ⬆️
server/clip_server/executors/clip_tensorrt.py 94.59% <0.00%> (+94.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jemmyshin jemmyshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemmyshin jemmyshin merged commit fd16e5a into main Dec 7, 2022
@jemmyshin jemmyshin deleted the fix-dtype-check branch December 7, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants