feat: support clip retrieval #816
Conversation
numb3r3
commented
Sep 8, 2022
•
numb3r3
commented
- support multi-model encoding
- add index and search API
Codecov Report
@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 83.90% 84.30% +0.40%
==========================================
Files 21 21
Lines 1466 1548 +82
==========================================
+ Hits 1230 1305 +75
- Misses 236 243 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| return self._unboxed_result(results) | ||
|
|
||
| @overload | ||
| async def aindex( |
There was a problem hiding this comment.
why do we need aindex in the client? The logic of index in the server is not blocked since we use a queue
There was a problem hiding this comment.
See tips in this section ->https://clip-as-service.jina.ai/user-guides/client/#async-encoding
scripts/streamlit.py
Outdated
| from client.clip_client.client import Client | ||
|
|
||
| client = Client('grpc://0.0.0.0:61000') | ||
| st.title('Laion400M retrieval') |
There was a problem hiding this comment.
Change the name to something more meaningful
There was a problem hiding this comment.
this streamlit script looks like a toy, I will delete it from this PR.
| @@ -118,9 +117,13 @@ def encode(self, content, **kwargs): | |||
| ) | |||
| results = DocumentArray() | |||
| with self._pbar: | |||
| parameters = kwargs.pop('parameters', None) | |||
There was a problem hiding this comment.
Just want to clean kwargs.
| @@ -1,7 +1,6 @@ | |||
| import mimetypes | |||
There was a problem hiding this comment.
I think we can reuse some codes in this file since its getting quite big
There was a problem hiding this comment.
yes, exactly. But this is not the response of this PR
There was a problem hiding this comment.
OK but don't do it too soon 🥲pls wait for my PRs
Co-authored-by: Ziniu Yu <ziniuyu@gmail.com>
|
|
||
|
|
||
| @pytest.fixture(params=['torch']) | ||
| def make_search_flow(tmpdir, port_generator, request): |
There was a problem hiding this comment.
where do you define this tmpdir?
There was a problem hiding this comment.
used as workspace in annlite executor
