Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no allow client to change server batch size #787

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Jul 28, 2022

This PR fix the following things:

  • the client can no longer change the server batch size by posting through parameters

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #787 (b2ebb1a) into main (87928a7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   85.92%   85.89%   -0.04%     
==========================================
  Files          21       21              
  Lines        1137     1134       -3     
==========================================
- Hits          977      974       -3     
  Misses        160      160              
Flag Coverage Δ
cas 85.89% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_onnx.py 85.71% <ø> (-0.23%) ⬇️
server/clip_server/executors/clip_tensorrt.py 100.00% <ø> (ø)
server/clip_server/executors/clip_torch.py 87.71% <ø> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87928a7...b2ebb1a. Read the comment docs.

@ZiniuYu ZiniuYu requested a review from numb3r3 July 28, 2022 06:11
@ZiniuYu ZiniuYu marked this pull request as ready for review July 28, 2022 06:11
@ZiniuYu ZiniuYu requested a review from a team July 28, 2022 06:12
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 1db43b4 into main Jul 28, 2022
@numb3r3 numb3r3 deleted the fix-server-batch branch July 28, 2022 06:26
@jemmyshin
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants