🐛 Fixed an issue with casting query string params on /top/reviews endpoint
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
============================================
+ Coverage 57.66% 57.85% +0.18%
Complexity 1361 1361
============================================
Files 339 339
Lines 5270 5270
============================================
+ Hits 3039 3049 +10
+ Misses 2231 2221 -10 ☔ View full report in Codecov by Sentry. |
irfan-dahir
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
@pushrbx Sorry, completely missed this one.
LGTM - Added a small fix as the TopReviewsTypeEnum was being passed into jikan as an object rather the type value which was throwing an exception.
$requestParams->get seems to be wrapping it back into an object - unsure why.
|
I'm going to fix the test errors before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548