Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fixed broadcast adapter func and random anime/manga endpoint #543

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Jun 23, 2024

@pushrbx pushrbx requested a review from a team as a code owner June 23, 2024 20:33
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 2.32558% with 42 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (7dd9625) to head (896c68f).

Files Patch % Lines
app/JikanApiModel.php 0.00% 32 Missing ⚠️
app/Features/QueryRandomAnimeHandler.php 0.00% 4 Missing ⚠️
app/Features/QueryRandomMangaHandler.php 0.00% 4 Missing ⚠️
app/Anime.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #543      +/-   ##
============================================
- Coverage     57.76%   57.39%   -0.38%     
- Complexity     1352     1361       +9     
============================================
  Files           339      339              
  Lines          5209     5243      +34     
============================================
  Hits           3009     3009              
- Misses         2200     2234      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N-Pu
Copy link

N-Pu commented Jun 24, 2024

Responses are still not filtering (sfw, unspecified - didn't check that). But I'll hope you fix it soon. Thanks for the response the other day.

@pushrbx
Copy link
Collaborator Author

pushrbx commented Jun 24, 2024

Responses are still not filtering (sfw, unspecified - didn't check that). But I'll hope you fix it soon. Thanks for the response the other day.

@N-Pu Did you checkout this version from this PR and check it locally? On my end out of 100 tries there were no nsfw items when I've added the sfw parameter.

@N-Pu
Copy link

N-Pu commented Jun 24, 2024

Responses are still not filtering (sfw, unspecified - didn't check that). But I'll hope you fix it soon. Thanks for the response the other day.

@N-Pu Did you checkout this version from this PR and check it locally? On my end out of 100 tries there were no nsfw items when I've added the sfw parameter.

Well, I actually tried it. Link didn't change in any case, so whenever sfw=true or =false I sometimes get responses with hentai. Maybe I'm doing something wrong on my end.

@pushrbx
Copy link
Collaborator Author

pushrbx commented Jun 26, 2024

@N-Pu Just to be clear: this version / fix is not on https://api.jikan.moe yet. Are you self-hosting? If yes and you cloned this version, and the bug still persist, then there is a problem.

@N-Pu
Copy link

N-Pu commented Jun 26, 2024

No-no, I'm not self hosting. I get the idea. Will wait when this commit will merge into master branch.

Copy link
Contributor

@irfan-dahir irfan-dahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irfan-dahir irfan-dahir merged commit 1b46890 into master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Anime::getBroadcastAttribute() function causes an error when adapting the "broadcast" attribute value
3 participants