Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚑 Fixed issue with empty query params causing errors #473

Merged
merged 2 commits into from
Jan 20, 2024
Merged

🚑 Fixed issue with empty query params causing errors #473

merged 2 commits into from
Jan 20, 2024

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Jan 19, 2024

Fixes #472
With this PR all empty query string parameters will be ignored. E.g. ?page=.

@pushrbx pushrbx requested a review from a team as a code owner January 19, 2024 21:35
irfan-dahir
irfan-dahir approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@irfan-dahir irfan-dahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pushrbx pushrbx merged commit 84da394 into master Jan 20, 2024
@pushrbx pushrbx deleted the hotfix/empty_query_params branch January 31, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfan-dahir irfan-dahir irfan-dahir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Empty query string parameters cause an internal server error
2 participants
@pushrbx @irfan-dahir