Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cache scope for container image build #459

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Dec 3, 2023

Fixes #457

I'm not entirely sure if this is going to be the best way to do it, but it worth a shot. The idea here is to have one set of cache elements per matrix build. If we consider the way docker uses cached layers during build, there might no need to include the branch and tag name in the scope value:

  1. docker builds the first few layers, which in case of jikan api the php extensions, composer dependencies, and roadrunner.
  2. then it takes the files of jikan and adds it to the image

Because of step one is being constant most of the time, it should work with just the cpu arch as a cache key.

@pushrbx pushrbx requested a review from a team as a code owner December 3, 2023 11:00
@pushrbx pushrbx merged commit b8e8ba9 into master Dec 18, 2023
@pushrbx pushrbx deleted the fix/container_publish_action_caching1 branch January 31, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Incorrect cache scope in container release github action
2 participants