-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a pre-built Docker image base #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To stress that this is just for testing the image build locally, and also a local reference
wip wip wip wip wip wip
jgehrcke
force-pushed
the
jp/dockerimage
branch
from
September 7, 2021 11:05
a77762c
to
018393b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker image build is rather heavy, and executed on every single GH actions run.
With this change, the
Dockerfile
in this repo uses a new image base: https://hub.docker.com/r/jgehrcke/github-repo-stats-baseThis includes
Now we're not following
python:3.8-slim-buster
as a moving target anymore. This is often a red flag in security-critical environments. But not so much here. It's fine when the base gets a little out of date with the upstream Linux distro every now and then.This approach / patch / PR is motivated by #24 and also my own observations where the Docker image build sometimes fails as of instabilities.