Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http client redirect race condition #964

Merged
merged 15 commits into from
Jul 7, 2024
Merged

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jun 24, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The HTTP client is a shared resource between go routines, so to handle this override we clone it.

@sverdlov93 sverdlov93 requested a review from yahavi June 24, 2024 16:27
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@sverdlov93 sverdlov93 added the bug Something isn't working label Jun 25, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 25, 2024
@sverdlov93 sverdlov93 requested review from yahavi and removed request for yahavi June 26, 2024 15:03
http/httpclient/client.go Outdated Show resolved Hide resolved
@sverdlov93 sverdlov93 merged commit ca94b45 into jfrog:dev Jul 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants