Add and use a new IsPathAccessible API before accessing the .git dir #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
changed the title
true if there's no permission to access the directory
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
sverdlov93
reviewed
Aug 17, 2024
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestIsPathExistsAndIsPathAccessible(t *testing.T) { |
There was a problem hiding this comment.
for isAccessible should we create a file without permissions and test that it returns false as expected?
There was a problem hiding this comment.
I tried adding a test that creates a file without permissions, but you have no idea how challenging it is to test this. The major challenge comes from the fact that Windows and Linux/MacOS treat files without permissions completely differently. It is hard to make all OS work inside a single test. The only option I found was to split the test into two files, so that only one of them compilers for Windows. This is due to a package that can handle Windows locking. I ended up giving up and just testing the IsPathAccessible API with non existing files. It's just not worth the complexity @sverdlov93.
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix jfrog/jfrog-cli#2442.
The PR adds a new
IsPathAccessibleAPI, in addition to the existingIsPathExistsfunctions. This is because the existingIsPathExistsreturnsfalsein case of any error that occurred while accessing the directory, and not only in the case that the directory doesn't exist.The new
IsPathAccessiblereturnsfalsein case the directory exists, but the user doesn't have permissions to access it. The usage of the new API by the Artifactory Upload code flow is expected to resolve the above issue.