-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New service for centralized config profile #1002
New service for centralized config profile #1002
Conversation
…entralized-config-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't yet reviewed this PR. I'll do so soon, but I've already noticed that you haven't yet added new API to the README. Go ahead and do so till I become available to review the PR.
…ation' into centralized-config-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's run go fmt ./...
on the code.
…entralized-config-implementation
…ed for centralized config usage
This pull requests contains a new service for centralized config profile with a GET profile endpoint implementation.
Few changes to function names for ErrorReport service were added in order to align all xsc services.
Note: There is 1 TODO comment to switch to the actual minimal version of Xsc for this feature. This will be updated when this version will be released (before this PR is merged)