Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert file exclusion for directory exclusion for JAS scanners #95

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jun 27, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

When using exclusion pattern from the flags, we need to convert it to file patterns that the JAS scanners work with instead of the directory pattern we ask at the flag (for sca exclusions)

Transformation:

pattern --> **/pattern/**

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 27, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit e820e14 into jfrog:dev Jun 27, 2024
9 checks passed
@attiasas attiasas deleted the fix_exclude branch June 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants