-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new git "count-contributors" command. #91
Conversation
# Conflicts: # go.mod # go.sum
# Conflicts: # cli/docs/flags.go
BitbucketServer = scmTypeName("bitbucket") | ||
DefaultContContributorsMonths = 3 | ||
getCommitsRetryNumber = 5 | ||
GithubTokenEnvVar = "JFROG_CLI_GITHUB_TOKEN" // #nosec G101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the comments at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The static analysis recognizes it as a secret- so I added it so it will be ignored.
} | ||
|
||
// Returns the Server details. The usage report is sent to this server. | ||
func (cc *CountContributorsCommand) ServerDetails() (*config.ServerDetails, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can delete this func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to implement it as part of the Command interface.
} | ||
|
||
// The command name for the usage report. | ||
func (cc *CountContributorsCommand) CommandName() string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can delete this func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to implement it as part of the Command interface.
Some of the errors start with capital letter and some with lower one. |
# Conflicts: # cli/docs/flags.go
📦 Vulnerable Dependencies✍️ Summary
🔬 Research DetailsDescription: |
dev
branch.go vet ./...
.go fmt ./...
.A new command that counts and aggregates information about the git provider contributors.
Depends on: jfrog/froggit-go#135