Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show violations in job summary if context provided #71

Merged
merged 15 commits into from
Jun 6, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented May 26, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

If context is provided to the scan (watches / project key)

the job summary says:

No vulnerabilities were found

but on the table format: the terminology is Violations (rather than vulnerabilities)
image

New summary content will be shown as follows:
image

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels May 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 26, 2024
@carmithersh
Copy link

please chnage the summary:
for build scan summary say
X violation found, Y unique vulnerabilities (Z total: z1 medium, z2 low)

for the artifacts :
X violation found, Y unique vulnerabilities (Z total: z1 medium, z2 low)

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 29, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit 19b2c90 into jfrog:dev Jun 6, 2024
9 checks passed
@attiasas attiasas deleted the fix_summary_format_violation branch June 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants