Curation go support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
requested changes
May 30, 2024
There was a problem hiding this comment.
- Please add description to the PR (Min req, maybe also a screen shot of running curation on go)
- Please update documentaion and link the PR to this
- Please expend the integration tests
TestCurationAuditto also include the new package managers projects. (currently only npm exists)
Comment on lines
440
to
444
| defer func() { | ||
| cacheFolder, err := utils.GetCurationCacheFolder() | ||
| require.NoError(t, err) | ||
| assert.NoError(t, fileutils.RemoveTempDir(cacheFolder)) |
There was a problem hiding this comment.
you can delete go cache only with sudo or root, now that you mention it, I will return it without failing on permission err
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
approved these changes
Jun 6, 2024
asafambar
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Depends on:
GetDependenciesListfor Go to accept an error handler build-info-go#255PR description:
This PR introduces curation support for Go. It utilizes the curation audit API to successfully build Go dependencies and saves the downloaded packages in an alternative cache during the tree construction. Once the complete Go project tree is built, it retrieves the curation status for each node in the tree.
Examples of
jf curation-auditoutput for Go project: