Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning and skip SCA scan when directory path doesn't exists #59

Merged
merged 5 commits into from
May 23, 2024
Merged

Add warning and skip SCA scan when directory path doesn't exists #59

merged 5 commits into from
May 23, 2024

Conversation

eranturgeman
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@eranturgeman eranturgeman added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 24, 2024
attiasas
attiasas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

commands/audit/scarunner.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 1, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
138b1e6 
…o add-warning-when-dir-for-scan-doesnt-exist
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@eranturgeman eranturgeman merged commit afc7409 into jfrog:dev May 23, 2024
13 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas