Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project env val in commands #148

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Aug 18, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

When validating if Project was provided we validate both env var and flag while passing only the value of the flag.
was only used at audit before this fix.

@attiasas attiasas added the bug Something isn't working label Aug 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@attiasas attiasas changed the title Use project env val and only validate it Use project env val in commands Aug 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 21, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit ba47070 into jfrog:dev Aug 21, 2024
8 of 9 checks passed
@attiasas attiasas deleted the use_project_env branch August 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants