Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add xsc analytics to docker-scan command #145

Merged
merged 11 commits into from
Aug 19, 2024
Merged

add xsc analytics to docker-scan command #145

merged 11 commits into from
Aug 19, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Aug 14, 2024 •
edited by attiasas
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@orz25 orz25 changed the base branch from main to dev August 14, 2024 12:49
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2024
@orz25 orz25 added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Aug 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25 orz25 requested a review from attiasas August 18, 2024 10:31
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@orz25
Merge remote-tracking branch 'upstream/dev' into add-xsc-analytics-to…
c9af8da 
…-docker-scan-command

# Conflicts:
#	commands/curation/curationaudit.go
#	commands/scan/downloadindexer.go
#	commands/xray/offlineupdate/offlineupdate.go
#	formats/sarifutils/sarifutils.go
#	utils/severityutils/severity.go
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 19, 2024
attiasas
attiasas reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, check out the comment

commands/scan/scan.go Outdated Show resolved Hide resolved
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit 4c7427d into jfrog:dev Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orz25 @attiasas